New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows old orders to get promo adjustments #2395

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@huoxito
Member

huoxito commented Jan 7, 2013

UNACTIVATABLE_ORDER_STATES already covers scenarios where a promo should
not be applied to an order

Fixes #2388

Made the change and updated a test case. I didn't run the all tests locally because the promo test suite is unbelievable slow in my machine. Let's see if all goes fine.

Allows old orders to get promo adjustments
UNACTIVATABLE_ORDER_STATES already covers scenarios where a promo should
not be applied to an order

Fixes #2388
@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Jan 7, 2013

Member

Looks good. I'll delete that checkout_spec test that is failing. Thank you for looking into this for us.

Member

radar commented Jan 7, 2013

Looks good. I'll delete that checkout_spec test that is failing. Thank you for looking into this for us.

@huoxito

This comment has been minimized.

Show comment
Hide comment
@huoxito

huoxito Jan 7, 2013

Member

Ah sorry I missed that test.

Member

huoxito commented Jan 7, 2013

Ah sorry I missed that test.

@radar radar closed this in a912c3f Jan 8, 2013

radar added a commit that referenced this pull request Jan 9, 2013

Allows old orders to get promo adjustments
UNACTIVATABLE_ORDER_STATES already covers scenarios where a promo should
not be applied to an order

Fixes #2388

Fixes #2395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment