Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor taxonomy js tree #2622
As we discussed in #2192, I re-did my changes on the split_core branch.
You've been doing a lot of great work!
I only needed to change a couple of lines on this branch to get the desired functionality: I wanted to be able to re-use the taxonomy tree editor elsewhere, which basically just required turning it into a function which accepts
(On my original PR, I made a lot more changes, but looks like the Spree::API stuff takes care of all that now).
One last note: has the procedure for running the tests changed? I'm confident this change doesn't break anything in admin/taxonomies/edit, but I don't know if there were other places that used the code, because I couldn't get the tests to run.
I generated the sample app and ran
Hey, thanks for updating this :)
Take a look at the
Ok, I was doing it wrong - I tried to run the tests from the root instead of within each component.
Thanks for letting me know. I went ahead and ran ./build.sh and all of the tests pass that passed in the original split_core branch.
I stored a diff of the test outputs between the PR branch and split_core so you can determine if that's acceptable or not.