Refactor backend mail method #2643

huoxito · 2013-03-02T20:12:28Z

A suggestion to remove the mail_method obj (and table) from Spree and just use Spree::Config instead. I could never understand why Spree would keep a collection of mail methods when all it needs, and actually uses, is a single one. This method should prove it, it's called by both Spree::Core::MailSetting and Spree::Core::MailInterceptor to override the action_mailer configs.

def self.current
  where(:environment => Rails.env).first
end

Another reason to remove the MailMethod model is that the table only has an environment and an active attr, besides the Rails defaults (I believe the active attribute is not used anywhere). All other fields are preferences already.

If this get merged in users could use if statements to define custom settings as per environment. e.g.

  if Rails.env.production?
    config.mail_port = "25"
  else
    config.mail_port = "1025"
  end

Please let me know what you think. The build still has some failing specs but I think that's related to taxons or something else. I made it in four commits just to state clearly what were the changes. I could squash them into one in case you guys intend to merge it in master.

huoxito · 2013-03-02T21:46:49Z

Missed MailInterceptor and MailSetting specs, I pushed one more to fix them and move them to /core/specs. I believe that's where they belong.

radar · 2013-03-19T04:05:19Z

It's done this way so that admins can modify it through the backend. I don't know how many admins would be modifying this information though. I've always thought it would be better suited in an initializer.

Thoughts on this @BDQ or @schof?

huoxito · 2013-03-19T13:10:18Z

It would still allow admin to edit settings through admin UI. But this PR makes that happen using Spree::Config instead of saving records on a spree_mail_methods table. And since it's done through Spree::Config users can also configure this on the initializer. I can't see a reason to have a list of mail method when Spree only uses MailMethod#current everywhere.

I'm aware that if this gets merged in the spree_mail_method table still needs to be dropped eventually and we'll need to update the docs. I'm willing to help with that too just in case.

radar · 2013-03-28T04:11:05Z

core/app/models/spree/mail_method.rb

@@ -1,32 +1,6 @@
 module Spree
-  class MailMethod < ActiveRecord::Base


Does this class still belong in models if it's not a model? I think a better place for it would be lib/spree/core/mail_method.rb, with the class then becoming Spree::Core::MailMethod.

Makes sense. I just realized I might as well just move the constants to the Spree::Core::MailSettings class and just get rid of the MailMethod Sounds good?

Yup, please do that.

On Thu, Mar 28, 2013 at 3:14 PM, Washington Júnior
notifications@github.com wrote:

@@ -1,32 +1,6 @@
module Spree

class MailMethod < ActiveRecord::Base
Makes sense. I just realized I might as well just move the constants to the Spree::Core::MailSettings class and just get rid of the MailMethod Sounds good?

Reply to this email directly or view it on GitHub:
https://github.com/spree/spree/pull/2643/files#r3564784

Ok!

On Thu, Mar 28, 2013 at 1:59 AM, Ryan Bigg notifications@github.com wrote:

In core/app/models/spree/mail_method.rb:

@@ -1,32 +1,6 @@
module Spree

class MailMethod < ActiveRecord::Base

Yup, please do that.
… <#13daf5d0f4bfb1e1_>
On Thu, Mar 28, 2013 at 3:14 PM, Washington Júnior <
notifications@github.com> wrote: > @@ -1,32 +1,6 @@ > module Spree > -
class MailMethod < ActiveRecord::Base Makes sense. I just realized I might
as well just move the constants to the Spree::Core::MailSettings class
and just get rid of the MailMethod Sounds good? --- Reply to this email
directly or view it on GitHub:
https://github.com/spree/spree/pull/2643/files#r3564784

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2643/files#r3565037
.

Washington Luiz B Jr
web developer

radar · 2013-03-28T04:12:27Z

Alright, I've looked over this again. It looks like a step in the right direction. Could you please move the MailMethod class as suggested. That's the last thing to do before this PR will be merged.

huoxito · 2013-03-28T18:47:01Z

@radar done. rebased and remove all references to MailMethod. Please take a look. Running backend spec now, which take ages on my local machine. Hopefully should be good to go.

huoxito · 2013-03-28T19:32:04Z

Fixed a backend controller spec related to this change. Got another error I think it's unrelated:

Promotion Adjustments coupon promotions should allow an admin to create a promotion that adds a 'free' item to the cart
Failure/Error: select2 "Create adjustment", :from => "Add action of type"
RuntimeError:
Could not find label by text Add action of type
/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:73:in `find_label_by_text'

/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:42:in`select2'

./spec/requests/admin/promotion_adjustments_spec.rb:221:in `block (3 levels) in <top (required)>'

huoxito · 2013-03-28T20:16:23Z

Also ran frontend specs. Got same similar errors as above. I believe this one is good to go.

radar · 2013-04-01T23:42:41Z

Tentatively adding this to master now. Will run it over the CI server and see what it says.

radar · 2013-04-09T05:26:03Z

CI server says all is green. Thanks @huoxito. Goodbye, MailMethod.

huoxito · 2013-04-10T12:28:42Z

Awesome @radar ! However I've notice it not made it to spree/spree master yet. Tested a merge locally and relized it does not apply cleanly anymore. Would like me to rebase it again on top of master?

radar · 2013-04-12T04:45:05Z

Hm... I don't know where it went!

Yes please rebase on master.

huoxito · 2013-04-12T05:03:41Z

Will do!

- Deletes new and index templates from mail methods - Removes mail_method model spec. It adds value to the test suite - Fixes requests and controllers specs related to mail method refactoring

Moves them to /core/spec/lib since both MailInterceptor and MailSettings are classes from the /core package

And the class itself. I believe the spree_mail_methods table should stay for now so that can core team can talk about a strategy to advise users the best way to upgrade and docs are updated

huoxito · 2013-04-12T13:54:51Z

It's rebased @radar Please merge :)

Looks like not much changed since the last rebase except for this 6eb8a0c Got 2 failing specs on backend which seem unrelated to this changes.

radar · 2013-04-17T04:55:31Z

Added to my master branch and running over CI. Thanks again @huoxito.

On Fri, Apr 12, 2013 at 11:54 PM, Washington Júnior <
notifications@github.com> wrote:

It's rebased @radar https://github.com/radar Please merge :)

Looks like not much changed since the last rebase except for this 6eb8a0chttps://github.com/spree/spree/commit/6eb8a0c10d6a4bc9abfbc67f0074220914123f63Got 2 failing specs on backend which seem unrelated to this changes.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2643#issuecomment-16294017
.

Ryan Bigg
Community Manager
Spree Commerce, Inc.

Register now for SpreeConf
May 20-21 in Washington, D.C.
http://spreeconf.com

Please give a look at the following links: - http://guides.spreecommerce.org/release_notes/spree_2_0_0.html#mailmethod-model-no-longer-exists - spree/spree#2643

Said class is removed in spree/spree#2643 in Spree.

radar reviewed Mar 28, 2013
View reviewed changes

radar closed this Apr 9, 2013

radar reopened this Apr 12, 2013

huoxito added 7 commits April 12, 2013 08:52

Makes mail method a single resource

fbafbac

Moves preferences from MailMethod to AppConfiguration

b889d19

Uses Spree::Config in MailSettings and MailInterceptor

4741082

Changes mail method form to use Spree::Config

03550de

- Deletes new and index templates from mail methods - Removes mail_method model spec. It adds value to the test suite - Fixes requests and controllers specs related to mail method refactoring

Adapts testmail action to new mail settings style

513b9ab

Fixes mail settings and interceptor specs

554a041

Moves them to /core/spec/lib since both MailInterceptor and MailSettings are classes from the /core package

Remove all remaining references to Spree::MailMethod

f1922c8

And the class itself. I believe the spree_mail_methods table should stay for now so that can core team can talk about a strategy to advise users the best way to upgrade and docs are updated

huoxito mentioned this pull request Apr 21, 2013

Allow users to not override default mailer configs (1-3-stable) #2918

Closed

radar closed this in 2037ac9 Apr 22, 2013

huoxito mentioned this pull request Apr 23, 2013

Allow users to not override default mailer configs #2929

Closed

huoxito deleted the refactor-backend-mail-method branch May 22, 2013 22:04

sauloperez mentioned this pull request Dec 21, 2017

Fix reference to MailMethod in base_mailer_decorator openfoodfoundation/openfoodnetwork#2016

Closed

sauloperez added a commit to coopdevs/openfoodnetwork that referenced this pull request Mar 7, 2018

Remove deprecated reference to Spree::MailMethod

c1f4aaf

Said class is removed in spree/spree#2643 in Spree.

sauloperez mentioned this pull request Mar 7, 2018

Remove deprecated reference to Spree::MailMethod openfoodfoundation/openfoodnetwork#2124

Merged

sauloperez added a commit to coopdevs/openfoodnetwork that referenced this pull request Mar 7, 2018

Remove reference to Spree::MailMethod from specs

599439d

Said class is removed in spree/spree#2643 in Spree.

sauloperez added a commit to coopdevs/openfoodnetwork that referenced this pull request Mar 7, 2018

Remove deprecated reference to Spree::MailMethod

1b39d57

Said class is removed in spree/spree#2643 in Spree.

sauloperez mentioned this pull request Mar 21, 2018

[Spree 2 Upgrade] Refactor CreateMailMethod to work on Spree 2.0 openfoodfoundation/openfoodnetwork#2164

Closed

HugsDaniel pushed a commit to HugsDaniel/openfoodnetwork that referenced this pull request Jun 4, 2018

Remove deprecated reference to Spree::MailMethod

f3dd599

Said class is removed in spree/spree#2643 in Spree.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor backend mail method #2643

Refactor backend mail method #2643

huoxito commented Mar 2, 2013

huoxito commented Mar 2, 2013

radar commented Mar 19, 2013

huoxito commented Mar 19, 2013

radar Mar 28, 2013

huoxito Mar 28, 2013

radar Mar 28, 2013

huoxito Mar 28, 2013

radar commented Mar 28, 2013

huoxito commented Mar 28, 2013

huoxito commented Mar 28, 2013

/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:73:in `find_label_by_text'

/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:42:in`select2'

./spec/requests/admin/promotion_adjustments_spec.rb:221:in `block (3 levels) in <top (required)>'

huoxito commented Mar 28, 2013

radar commented Apr 1, 2013

radar commented Apr 9, 2013

huoxito commented Apr 10, 2013

radar commented Apr 12, 2013

huoxito commented Apr 12, 2013

huoxito commented Apr 12, 2013

radar commented Apr 17, 2013

		@@ -1,32 +1,6 @@
		module Spree
		class MailMethod < ActiveRecord::Base

Refactor backend mail method #2643

Refactor backend mail method #2643

Conversation

huoxito commented Mar 2, 2013

huoxito commented Mar 2, 2013

radar commented Mar 19, 2013

huoxito commented Mar 19, 2013

radar Mar 28, 2013

Choose a reason for hiding this comment

huoxito Mar 28, 2013

Choose a reason for hiding this comment

radar Mar 28, 2013

Choose a reason for hiding this comment

huoxito Mar 28, 2013

Choose a reason for hiding this comment

radar commented Mar 28, 2013

huoxito commented Mar 28, 2013

huoxito commented Mar 28, 2013

/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:73:in `find_label_by_text'

/home/washington/projetos/spree/core/lib/spree/testing_support/capybara_ext.rb:42:in`select2'

./spec/requests/admin/promotion_adjustments_spec.rb:221:in `block (3 levels) in <top (required)>'

huoxito commented Mar 28, 2013

radar commented Apr 1, 2013

radar commented Apr 9, 2013

huoxito commented Apr 10, 2013

radar commented Apr 12, 2013

huoxito commented Apr 12, 2013

huoxito commented Apr 12, 2013

radar commented Apr 17, 2013