New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracking_url field to shipping methods #2644

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@joshnuss
Contributor

joshnuss commented Mar 2, 2013

This feature adds the ability for tracking numbers to be clickable throughout the system.

Without it, the customer needs to locate the tracking website themselves and copy and paste the tracking number (except gmail users). It also effects admins who are trying to investigate the history of a shipment, it would be helpful if they could just click on the tracking and open up the tracking site.

A new column tracking_url was added to ShippingMethod model. The tracking_url stores an example tracking link with the token :tracking in place of the actual number. e.g. http://quickship.com/tracking?n=:tracking. The :tracking part is interpolated with the actual tracking number at runtime.

This new field is totally optional, when left empty everything reverts to unlinked tracking numbers

The link is displayed in the following templates:

  • shared/order_details
  • admin/shipments/index
  • shipment_mailer/shipped_email

We may want to add the tracking to the order listing on the account page too, since many users are going into the account page to check on the status of their orders.

Edit Shipping Method

Empty Tracking Placeholder Text

Order Screen Tracking Link

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Mar 4, 2013

Member

@schof, @BDQ, @cmar thoughts on having tracking_url be a feature of shipments on Spree?

Member

radar commented Mar 4, 2013

@schof, @BDQ, @cmar thoughts on having tracking_url be a feature of shipments on Spree?

@GeekOnCoffee

This comment has been minimized.

Show comment
Hide comment
@GeekOnCoffee

GeekOnCoffee Mar 4, 2013

Contributor

Some tracking services require a POST rather than a GET... but otherwise seems like a cool bit of functionality... I'd love to see it as an extension if it's deemed not a core feature

Contributor

GeekOnCoffee commented Mar 4, 2013

Some tracking services require a POST rather than a GET... but otherwise seems like a cool bit of functionality... I'd love to see it as an extension if it's deemed not a core feature

@BDQ

This comment has been minimized.

Show comment
Hide comment
@BDQ

BDQ Mar 4, 2013

Member

I think this is ok to have in core, it's a relatively small feature (with zero dependencies) and we've seen this feature implemented a lot for existing stores.

Member

BDQ commented Mar 4, 2013

I think this is ok to have in core, it's a relatively small feature (with zero dependencies) and we've seen this feature implemented a lot for existing stores.

@joshnuss

This comment has been minimized.

Show comment
Hide comment
@joshnuss

joshnuss Mar 4, 2013

Contributor

@GeekOnCoffee thanks. btw, for those that need http POST, this feature still makes it a little easier, cause you could just override the link_to_tracking helper to generate a <form> instead of <a>

Contributor

joshnuss commented Mar 4, 2013

@GeekOnCoffee thanks. btw, for those that need http POST, this feature still makes it a little easier, cause you could just override the link_to_tracking helper to generate a <form> instead of <a>

@radar radar closed this in 650e301 Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment