Taxon seo #2787

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@sbounmy
Contributor

sbounmy commented Mar 30, 2013

this pull request allow taxon seo customization.
I've also added some custom rspec matchers : have_title and have_meta

@futhr

This comment has been minimized.

Show comment Hide comment
@futhr

futhr Mar 31, 2013

Contributor

+1

But a small comment that meta-tags are for the major search engines today just an indicator that the site might be spamming keywords if you read (and trust) the latest seo reports, so meta-keywords should be within valuation a deprecated feature and maybe only be used for supplying additional support to internal search and tag clouds.

...should this not be pushed to master. I wonder if it wise to add additional fields to a stable branch?

Contributor

futhr commented Mar 31, 2013

+1

But a small comment that meta-tags are for the major search engines today just an indicator that the site might be spamming keywords if you read (and trust) the latest seo reports, so meta-keywords should be within valuation a deprecated feature and maybe only be used for supplying additional support to internal search and tag clouds.

...should this not be pushed to master. I wonder if it wise to add additional fields to a stable branch?

@joneslee85

This comment has been minimized.

Show comment Hide comment
@joneslee85

joneslee85 Apr 1, 2013

Member

@sbounmy looks good to me, +1 from me, if @radar or any core team votes for this, I am happy to merge
@futhr do you have any sources to backup your point?

Member

joneslee85 commented Apr 1, 2013

@sbounmy looks good to me, +1 from me, if @radar or any core team votes for this, I am happy to merge
@futhr do you have any sources to backup your point?

@futhr

This comment has been minimized.

Show comment Hide comment
@futhr

futhr Apr 1, 2013

Contributor

@joneslee85 I read an interview/article with some Google guy about it when I was doing an research to update myself about general usage of meta tags for HTML5. But I have to get back to you when I find the reference again, this is as always opinionated know-how when it comes to seo best practices. Well, of course I don't rely on one source so I use to check major websites built on HTML5 and I see that its a common pattern that its being dropped together with may other meta types that was common before.

Contributor

futhr commented Apr 1, 2013

@joneslee85 I read an interview/article with some Google guy about it when I was doing an research to update myself about general usage of meta tags for HTML5. But I have to get back to you when I find the reference again, this is as always opinionated know-how when it comes to seo best practices. Well, of course I don't rely on one source so I use to check major websites built on HTML5 and I see that its a common pattern that its being dropped together with may other meta types that was common before.

@sbounmy

This comment has been minimized.

Show comment Hide comment
@sbounmy

sbounmy Apr 1, 2013

Contributor

@futhr I also heard about meta-keywords deprecation, but I wanted to keep it consistent with products which had meta-keywords.
IMHO this is a quite straightforward pull request so it can be pushed to master and 1-3-stable

Contributor

sbounmy commented Apr 1, 2013

@futhr I also heard about meta-keywords deprecation, but I wanted to keep it consistent with products which had meta-keywords.
IMHO this is a quite straightforward pull request so it can be pushed to master and 1-3-stable

@radar

This comment has been minimized.

Show comment Hide comment
@radar

radar Apr 3, 2013

Member

Looks good to me too.

Member

radar commented Apr 3, 2013

Looks good to me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment