Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add preference to allow product_description to be rendered raw. #2874
There was a bug in the spree editor whereby if the WYSIWYG editor that we used output something that met the regex that the current product description code was checking for that we would get some bad output. Read the issue for more details.
I thought that the correct way to solve this problem would be to add a Spree preference and then we could make use of it in the spree_editor code as you can see in this branch here which will soon be a pull request.
I would like to see this pull request merged into both master and 1-3-stable if at all possible. I made this change off 1-3-stable so I raised the PR against it.
I have also followed the "guidelines for contributing" and have written a single test case for this relatively small change.
Thankyou very much for you time in reviewing this pull request I really do appreciate it and Spree and am hoping to help by continuing to commit bug fixes and other changes that I find along the way. Please let me know if I have done it wrong and I'll fix it up.
Sweet, I did not know you had that. I am very new to Spree. I'll remove that line happily. Thanks!
Edit: Based on the fact that we have this in spec_helper.rb I think it should be cleaned out before every test:
I will just remove this one line.