Set cc_type server-side in case of js failure #3918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks @NathanielWroblewski for the terrific work. |
|
Applied this commit to my 2-1-stable and master branches. |
radar
pushed a commit
that referenced
this pull request
Oct 31, 2013
|
My pleasure, @radar. Thanks! |
jhawthorn
added a commit
to jhawthorn/solidus
that referenced
this pull request
Sep 28, 2016
The existing hash was incomplete, missing some brands. It was also missing MasterCard's new (October 2016) BIN range (222100-272099). This hash was originally added in spree/spree#3918 and has not been changed since. I don't know the original source, but I would rather trust the Hash taken from ActiveMerchant. One notable difference is that this will treat maestro and mastercard as separate brands. NB: For most stores, this code will not be run, and instead jquery.payment on the frontend will be responsible for providing the credit card brand.
bbuchalter
pushed a commit
to TommyJohnWear/solidus
that referenced
this pull request
Nov 18, 2016
The existing hash was incomplete, missing some brands. It was also missing MasterCard's new (October 2016) BIN range (222100-272099). This hash was originally added in spree/spree#3918 and has not been changed since. I don't know the original source, but I would rather trust the Hash taken from ActiveMerchant. One notable difference is that this will treat maestro and mastercard as separate brands. NB: For most stores, this code will not be run, and instead jquery.payment on the frontend will be responsible for providing the credit card brand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cc_typeis set on the client-side usingjquery.payments. This creates a single point of failure at malfunctioning or disabled javascript given that the lack of acc_typeon a payment source causes some spree gateways to fail. This pull request adds a redundant check on the server-side for cases where the javascript either fails or is disabled.CreditCard#expiry=to remove whitespace and split on'/'instead of splitting on' / 'because when js fails, a user entry of'04/12'will break.CreditCard#cc_type=to match a type based on the card number whencc_typeis an empty string, as is the case when js fails.