Refactor validations #6815
Merged
Refactor validations #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage to preview changes. Open stage or view logs. |
| validates :stock_item | ||
| validates :quantity, numericality: { | ||
| greater_than_or_equal_to: -2**31, | ||
| less_than_or_equal_to: 2**31-1, |
There was a problem hiding this comment.
Surrounding space missing for operator '-'.
| @@ -75,7 +75,7 @@ def index | |||
| resource.valid? # get some errors | |||
| expect(subject).to receive(:index).and_raise(ActiveRecord::RecordInvalid.new(resource)) | |||
| get :index, token: 'exception-message' | |||
| expect(json_response).to eql('exception' => "Validation failed: Name can't be blank, Price can't be blank, Shipping category can't be blank") | |||
| expect(json_response).to eql('exception' => "Validation failed: Name can't be blank, Shipping category can't be blank, Price can't be blank") | |||
| validates :item_count, numericality: { greater_than_or_equal_to: 0, less_than: 2**31, only_integer: true, allow_blank: true } | ||
| end | ||
| validates :payment_state, inclusion: { in: ['balance_due', 'paid', 'credit_owed', 'failed', 'void'], allow_blank: true } | ||
| validates :shipment_state, inclusion: { in: ['ready', 'pending', 'partial', 'shipped', 'backorder', 'canceled'], allow_blank: true } |
There was a problem hiding this comment.
Line is too long. [145/120]
Unnecessary spacing detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.