New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Spree::StoreController#apply_coupon_code #7284

Merged
merged 1 commit into from Apr 13, 2016

Conversation

Projects
None yet
2 participants
@damianlegawiec
Member

damianlegawiec commented Apr 13, 2016

This method isn’t used anymore as frontend is applying coupon codes via API V1

Removing Spree::StoreController#apply_coupon_code
This method isn’t used anymore as frontend is applying coupon codes via
API V1

@damianlegawiec damianlegawiec added this to the v3.2.x milestone Apr 13, 2016

@priyank-gupta priyank-gupta merged commit c613bfb into spree:master Apr 13, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

mtomov added a commit to mtomov/solidus that referenced this pull request Apr 21, 2016

Improve coupon code JS applicator
  - separate Coupon code application from Saving & processing a payment

    => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

mtomov added a commit to mtomov/solidus that referenced this pull request Apr 21, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

mtomov added a commit to mtomov/solidus that referenced this pull request Apr 29, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

mtomov added a commit to mtomov/solidus that referenced this pull request May 6, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

peterberkenbosch added a commit to peterberkenbosch/solidus that referenced this pull request Jul 30, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

adaddeo added a commit to pervino/solidus that referenced this pull request Nov 8, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

bbuchalter added a commit to TommyJohnWear/solidus that referenced this pull request Nov 18, 2016

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284

mgharbik pushed a commit to mgharbik/solidus that referenced this pull request Jan 28, 2018

Improve coupon code JS applicator
 - separate Coupon code application from Saving & processing a payment

   => allows users to first apply a code, and subsequently add payment
       details when they are certain of the final amount to be paid.

 - Add new button Apply Code

 - Separate payment js from coupon code js - allows for easier override
   as they are now in separate files.

 - Allow customisation of the CSS classes applied on success and on error
   via data attributes `data-success-class` and `data-success-error`.

 - Fix a refresh bug on coupon code application error - before, the page
   was refreshed even after displaying an AJAX brought error message.
   See issue & fix @spree spree/spree#7040

 - Fixes a JS warning that a Synchronous AJAX request was executed, which
   could impact JS performance as it waits for response from the server
   before continuing the execution of the JS.
   (Was coming from the `async:false` setting in `Spree.ajax`)

 - Switch to using the Spree API action for applying a code instead of the
   Frontend controller one at StoreController#apply_code.

   TODO: Delete the StoreController#apply_code similarly to Spree as
         it's not used anymore. See: spree/spree#7284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment