Fixed: don't destroy dependent associations if we cannot destroy the User #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishalzambre can we have a spec? such change can be a major regression maker |
|
@joneslee85 Sure will update spec. |
vishalzambre
force-pushed
the
user_before_destroy
branch
from
18b64b1
to
fc87e73
Compare
|
@joneslee85 updated with spec |
|
Thanks @vishalzambre 👍 |
damianlegawiec
added a commit
to spark-solutions/spree_auth_devise
that referenced
this pull request
Jul 28, 2016
…serMethods spree/spree#7430 in spree fixed user deletion validation and this caused some outdated specs in spree_auth_devise to fail.
krzysiek1507
added
backported to 3-1-stable
and removed
needs backport to 3-1-stable
labels
hishammalik
pushed a commit
to arkhitech/spree_auth_devise
that referenced
this pull request
Feb 10, 2018
…serMethods spree/spree#7430 in spree fixed user deletion validation and this caused some outdated specs in spree_auth_devise to fail.
freedeveloper000
added a commit
to freedeveloper000/spree_auth_devise
that referenced
this pull request
Feb 28, 2022
…serMethods spree/spree#7430 in spree fixed user deletion validation and this caused some outdated specs in spree_auth_devise to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
check_completed_orderstoUserMethodsmodulePreviously :check_completed_orders callback could stop deleting the
User but associations (with dependent: :destroy) were
deleted whatsoever, as this is a rails bug (see
rails/rails#3458)