New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tackle I18n problem of 'state' #7557

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
2 participants
@orbit-dna
Contributor

orbit-dna commented Aug 28, 2016

it's about i18n of state, #7534

I noticed there is a :status, and :state seems being used as region/province rather than status by many locales.
some example:

locale state status
:en State Status
:zh-CN 省份 状态
:ja 都道府県(州) 状況
:fr Province / Région / État Statut
:de Bundesland Status
:ru Регион/Область Статус
:ko -- 상태
:es Provincia Estatus
:it Stato Stato

so I think it's better to change the miss-used status _:state_s to :status

tackle I18n problem of 'state'
in some templates, i18n key :state is used to express status, but the
result turn out to be kind of province/region.
change these :states to :status.

@damianlegawiec damianlegawiec merged commit 429ecbf into spree:master Aug 30, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
@damianlegawiec

This comment has been minimized.

Show comment
Hide comment
@damianlegawiec
Member

damianlegawiec commented Aug 30, 2016

Thanks @orbit-dna 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment