Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admin/countries_controller.rb indentation issue #7558

Closed
wants to merge 2 commits into from
Closed

fix admin/countries_controller.rb indentation issue #7558

wants to merge 2 commits into from

Conversation

nimish13
Copy link
Contributor

No description provided.

@tanmay3011
Copy link
Contributor

@nimish13 Avoid fixing indentation issues if there's no code change as it makes tracking of code history difficult.

@nimish13
Copy link
Contributor Author

@Tanmay I feel fixing indentation is equally important as fixing a bug.
There may be a case where there is no optimization/fix in the code and in that case if there is some indentation issue that will never be fixed and it may make code look unpresentable.What is your thought about that?

@tanmay3011
Copy link
Contributor

tanmay3011 commented Aug 29, 2016

@nimish13 I would prefer to have commit history correct over the presentation. In case indentation needs to be fixed, I would prefer to have a single fix throughout the code rather than having 1000 commits separately. Though I'm against fixing indentations until there's a code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants