New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add created at to variant #7627

Merged
merged 2 commits into from Oct 14, 2016

Conversation

Projects
None yet
3 participants
@Argonus
Contributor

Argonus commented Oct 14, 2016

  • Add created_at to spree_variant
  • In migration add update_all spree_variants created_at and updated_at
  • Add not null for spree_variants timestamps
  • Add specs

Argonus added some commits Oct 14, 2016

Create migration adding created_at to spree_variant, update all varia…
…nts timestamps.

Update all variant with not null updated_at to have same created_at and
updated_at
Update all variant with null updated_at to have
@@ -0,0 +1,6 @@
class AddNullFalseToSpreeVariantsTimestamps < ActiveRecord::Migration[5.0]

This comment has been minimized.

@houndci-bot

houndci-bot Oct 14, 2016

Missing frozen string literal comment.

@houndci-bot

houndci-bot Oct 14, 2016

Missing frozen string literal comment.

@@ -0,0 +1,8 @@
class AddCreatedAtToVariant < ActiveRecord::Migration[5.0]

This comment has been minimized.

@houndci-bot

houndci-bot Oct 14, 2016

Missing frozen string literal comment.

@houndci-bot

houndci-bot Oct 14, 2016

Missing frozen string literal comment.

@damianlegawiec damianlegawiec merged commit f636403 into spree:master Oct 14, 2016

1 of 3 checks passed

ci/circleci A command timed out during your tests
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
hound 2 violations found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment