New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for discontinue_on in admin product index. #7686

Merged
merged 2 commits into from Nov 16, 2016

Conversation

Projects
None yet
3 participants
@joeswann
Contributor

joeswann commented Nov 16, 2016

  • Fixes an issue where admin index is not filtering by whether a product is discontinued.
  • Fixes an issue where the admin product index isn't filtering out discontinued products by default.

Issue: #7365 (comment)
Request for PR: #7683 (comment)

joeswann added some commits Nov 16, 2016

Add discontinue_on to Spree::Product ransackable_attributes
Fixes an issue where admin index is not filtering by whether a product is discontinued.

Issue: #7365 (comment)
Add default discontinue_on to admin product index
Fixes an issue where the admin product index isn't filtering out discontinued products by default.

Issue: #7365 (comment)

@damianlegawiec damianlegawiec merged commit 2328cc2 into spree:master Nov 16, 2016

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment