New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source branding #7707

Merged
merged 4 commits into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@damianlegawiec
Member

damianlegawiec commented Nov 29, 2016

  • new Spree logo for frontend
  • new Spree logo for Admin Panel
  • changed where available links to spreecommerce.org
@@ -914,7 +914,7 @@ def commit(sha)
"name"=> "dotcom",
"display"=> "Dotcom Distribution",
"description"=> "Order fulfillment and tracking using Dotcom Distribution",
"help"=> "http://guides.spreecommerce.com/integration/dotcom_integration.html",
"help"=> "http://guides.spreecommerce.org/integration/dotcom_integration.html",

This comment has been minimized.

@houndci-bot

houndci-bot Nov 29, 2016

Surrounding space missing for operator =>.

@houndci-bot

houndci-bot Nov 29, 2016

Surrounding space missing for operator =>.

@@ -19,7 +18,8 @@
margin-bottom: 10px;
img {
width: 100%;
max-width: 100%;

This comment has been minimized.

@houndci-bot

houndci-bot Nov 29, 2016

Properties should be ordered max-height, max-width

@houndci-bot

houndci-bot Nov 29, 2016

Properties should be ordered max-height, max-width

expect(response.status).to eq(200)
expect(json_response['user_id']).to eq(user.id)
end
end
it "can assign an email to the order" do
api_put :update, id: order.to_param, order_token: order.guest_token,
order: { email: "guest@spreecommerce.com" }
expect(json_response['email']).to eq("guest@spreecommerce.com")
order: { email: "guest@spreecommerce.org" }

This comment has been minimized.

@houndci-bot

houndci-bot Nov 29, 2016

Align the elements of a hash literal if they span more than one line.

@houndci-bot

houndci-bot Nov 29, 2016

Align the elements of a hash literal if they span more than one line.

@@ -269,16 +269,16 @@ def controller.load_order(*)
user = create(:user)
# Need to pass email as well so that validations succeed
api_put :update, id: order.to_param, order_token: order.guest_token,
order: { user_id: user.id, email: "guest@spreecommerce.com" }
order: { user_id: user.id, email: "guest@spreecommerce.org" }

This comment has been minimized.

@houndci-bot

houndci-bot Nov 29, 2016

Align the elements of a hash literal if they span more than one line.

@houndci-bot

houndci-bot Nov 29, 2016

Align the elements of a hash literal if they span more than one line.

@damianlegawiec damianlegawiec merged commit 864b5d9 into spree:master Nov 29, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 4 violations found.

@krzysiek1507 krzysiek1507 deleted the spark-solutions:feature/oss-branding branch Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment