New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Paperclip to v5.1.0 #7858

Merged
merged 2 commits into from Mar 19, 2017

Conversation

Projects
None yet
2 participants
@joshRpowell
Contributor

joshRpowell commented Mar 19, 2017

Description

Bumping Paperclip to v5.1.0

Motivation and Context

We've been running Spree 3.2.0.x & Paperclip 5.1.0 in production since Spree added Rails 5.0 compatibility.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Post-install message from paperclip:
##################################################

NOTE FOR UPGRADING FROM 4.3.0 OR EARLIER

##################################################

Paperclip is now compatible with aws-sdk >= 2.0.0.

If you are using S3 storage, aws-sdk >= 2.0.0 requires you to make a few small
changes:

  • You must set the s3_region
  • If you are explicitly setting permissions anywhere, such as in an initializer,
    note that the format of the permissions changed from using an underscore to
    using a hyphen. For example, :public_read needs to be changed to
    public-read.

For a walkthrough of upgrading from 4 to 5 and aws-sdk >= 2.0 you can watch
http://rubythursday.com/episodes/ruby-snack-27-upgrade-paperclip-and-aws-sdk-in-prep-for-rails-5

@damianlegawiec

This comment has been minimized.

Show comment
Hide comment
@damianlegawiec
Member

damianlegawiec commented Mar 19, 2017

Thanks @joshRpowell 👍

@damianlegawiec damianlegawiec merged commit 46ad471 into spree:master Mar 19, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment