New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove minimum length validation on product slug #8028

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
4 participants
@vfonic
Contributor

vfonic commented May 31, 2017

  • There's no specific need to have this code in the core. Anyone willing
    to have this functionality, can easily add it to their own code.
@vfonic

This comment has been minimized.

Show comment
Hide comment
@vfonic

vfonic May 31, 2017

Contributor

Closes #8027

Contributor

vfonic commented May 31, 2017

Closes #8027

Core: Remove minimum length validation on product slug
* There's no specific need to have this code in the core. Anyone willing
  to have this functionality, can easily add it to their own code.
@houndci-bot

Some files could not be reviewed due to errors:

/tmp/d20170601-22111-1fax751/.rubocop.yml: Style/DotPosition has the wrong na...
/tmp/d20170601-22111-1fax751/.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
/tmp/d20170601-22111-1fax751/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
Error: The Style/DeprecatedHashMethods cop has been renamed to Style/PreferredHashMethods.
(obsolete configuration found in /tmp/d20170601-22111-1fax751/.rubocop.yml, please update it)
/tmp/d20170601-29776-4zgitm/.rubocop.yml: Style/DotPosition has the wrong nam...
/tmp/d20170601-29776-4zgitm/.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
/tmp/d20170601-29776-4zgitm/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
Error: The Style/DeprecatedHashMethods cop has been renamed to Style/PreferredHashMethods.
(obsolete configuration found in /tmp/d20170601-29776-4zgitm/.rubocop.yml, please update it)

@damianlegawiec damianlegawiec merged commit b60dda6 into spree:master Jun 6, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment