New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused Shipment methods #8106

Merged
merged 3 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@damianlegawiec
Member

damianlegawiec commented Jul 7, 2017

No description provided.

damianlegawiec added some commits Jul 7, 2017

Deprecate Shipment#editable_by?
This is a leftover of Spree 1.0.0 times, when we didn't use cancancan
for authorizations
Deprecate Shipment#send_shipped_email
This method is the same as ShipmentHandler#send_shipped_email
Operations like this should be handler by ShipmentHandler

@symarys symarys merged commit 9972a78 into spree:master Jul 7, 2017

1 check passed

hound No violations found. Woof!

@krzysiek1507 krzysiek1507 deleted the spark-solutions:deadweight/shipment-methods branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment