New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop shoulda matchers dependency #8158

Merged
merged 6 commits into from Jul 25, 2017

Conversation

Projects
None yet
1 participant
@damianlegawiec
Member

damianlegawiec commented Jul 22, 2017

We should write more usage scenario specs, testing rails behavior is kind of pointless...

Remove testing delegations
This is very buggy in shoulda matchers

@damianlegawiec damianlegawiec requested a review from krzysiek1507 Jul 22, 2017

damianlegawiec added some commits Jul 22, 2017

Removing testing out associations
We don’t need to test out standard rails mechanisms…
Removing shoulda-callback-matchers
Testing out standard rails mechanisms is an unwanted overhead
Removing shoulda matchers dependency
We need more feature / integration specs not testing out standard rails
mechanisms

@damianlegawiec damianlegawiec changed the title from Drop shoulda matchers depndency to Drop shoulda matchers dependency Jul 24, 2017

@damianlegawiec damianlegawiec merged commit 1d1b0a3 into spree:master Jul 25, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment