New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin field_container now supports options like content_tag does #8163

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
2 participants
@delphaber
Contributor

delphaber commented Jul 24, 2017

In this way we can add, e.g., data attributes to field_container.

<%= field_container f.object, :company, class: ["form-group", "#{type}-row"], 'data-foo' => 'bar' do %>
...
<% end %
@delphaber

This comment has been minimized.

Show comment
Hide comment
@delphaber

delphaber Jul 24, 2017

Contributor

I noticed that spree already uses data attributes on field_container like in backend/app/views/spree/admin/countries/_form.html.erb.

Contributor

delphaber commented Jul 24, 2017

I noticed that spree already uses data attributes on field_container like in backend/app/views/spree/admin/countries/_form.html.erb.

@damianlegawiec

This comment has been minimized.

Show comment
Hide comment
@damianlegawiec
Member

damianlegawiec commented Jul 24, 2017

Nice @delphaber 👍

@damianlegawiec damianlegawiec merged commit 2fcde7e into spree:master Jul 24, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment