New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some frontend views cleanup #8174

Merged
merged 5 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@damianlegawiec
Member

damianlegawiec commented Jul 27, 2017

  • removed duplicated unused store/cart_link partial, only shared/link_to_cart is used
  • moved payments/payment into shared/payment
  • extracted shared/products product row into a separate products/product partial & use collection rendering
  • removed unused cycle reference in products list

damianlegawiec added some commits Jul 27, 2017

Move single product row into a separate partial
This will allow more flexibility for developers and reuse of this
partial in more scenarios
Move frontend payments/payment view into orders/payment
This is only used in the order view so no need to have in a different
directory
Removing unused store/cart_link view
Only the shared/link_to_cart is actually used
Move payment partial into spree/shared
It’s used in order_details partial and to keep consistency it should be
also in the shared directory

@damianlegawiec damianlegawiec requested a review from symarys Jul 27, 2017

@symarys symarys merged commit e9d9c6a into spree:master Jul 27, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

@symarys symarys deleted the spark-solutions:hotfix/frontend-views-cleanup branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment