New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated delegate_belongs_to #8179

Merged
merged 3 commits into from Aug 11, 2017

Conversation

Projects
None yet
5 participants
@Punkbooster
Contributor

Punkbooster commented Jul 28, 2017

No description provided.

@krzysiek1507

This comment has been minimized.

Show comment
Hide comment
@krzysiek1507
Contributor

krzysiek1507 commented Jul 28, 2017

@@ -118,6 +113,22 @@ class Product < Spree::Base
self.whitelisted_ransackable_attributes = %w[description name slug discontinue_on]
self.whitelisted_ransackable_scopes = %w[not_discontinued]
[

This comment has been minimized.

@houndci-bot

houndci-bot Aug 11, 2017

Use %i or %I for an array of symbols.

@houndci-bot

houndci-bot Aug 11, 2017

Use %i or %I for an array of symbols.

@@ -26,6 +21,11 @@ def has_default_price?
!self.default_price.nil?
end
def find_or_build_default_price

This comment has been minimized.

@houndci-bot

houndci-bot Aug 11, 2017

Use empty lines between method definitions.

@houndci-bot

houndci-bot Aug 11, 2017

Use empty lines between method definitions.

@@ -26,6 +21,11 @@ def has_default_price?
!self.default_price.nil?
end

This comment has been minimized.

@houndci-bot

houndci-bot Aug 11, 2017

Extra blank line detected.

@houndci-bot

houndci-bot Aug 11, 2017

Extra blank line detected.

@damianlegawiec damianlegawiec changed the title from Remove deprecated delegate_belongs_to to Deprecated delegate_belongs_to Aug 11, 2017

@damianlegawiec damianlegawiec self-requested a review Aug 11, 2017

@damianlegawiec damianlegawiec merged commit ccf237f into spree:master Aug 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 3 violations found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment