New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Variant#having_orders & Variant#on_backorder #8225

Merged
merged 2 commits into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@damianlegawiec
Member

damianlegawiec commented Aug 10, 2017

This scope became obsolete after
6a33007

damianlegawiec added some commits Aug 10, 2017

Deprecate Variant#having_orders
This scope became obsolete after
6a33007
Deprecate Variant#on_backorder
This method isn't used anywhere in the codebase for ages

@damianlegawiec damianlegawiec changed the title from Deprecate Variant#having_orders to Deprecate Variant#having_orders & Variant#on_backorder Aug 11, 2017

@damianlegawiec damianlegawiec requested a review from symarys Aug 11, 2017

@symarys symarys merged commit 7e2e7d3 into spree:master Aug 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

@symarys symarys deleted the spark-solutions:deprecations/variant-having-orders branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment