New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue when content of link to cart was escaped #852

Closed
wants to merge 2 commits into
base: 0-70-stable
from

Conversation

Projects
None yet
2 participants
@mikz
Contributor

mikz commented Dec 7, 2011

problem was following: link_to_cart calls order_currency
(which is properly marked as html_safe), but concatenates it
with another string, resulting to html unsafe string

fix is following: if no argument is passed to link_to_cart
use value from i18n, otherwise escape passed value
then create content of link and mark it as html safe

mikz added some commits Dec 7, 2011

fixed issue when content of link to cart was escaped
problem was following: link_to_cart calls order_currency
(which is properly marked as html_safe), but concatenates it
with another string, resulting to html unsafe string

fix is following: if no argument is passed to link_to_cart
use value from i18n, otherwise escape passed value
then create content of link and mark it as html safe
@mikz

This comment has been minimized.

Show comment
Hide comment
@mikz

mikz Dec 7, 2011

Contributor

I've also fixed one little escaping issue in cart view. Now order_price is properly not escaped.

Contributor

mikz commented Dec 7, 2011

I've also fixed one little escaping issue in cart view. Now order_price is properly not escaped.

@radar radar closed this in c9e0179 Dec 8, 2011

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Dec 8, 2011

Member

Also in @190c508a90485ad25dc7979cd9fca04193b7f879, just missed tagging that one too.

Thanks for your patch!

Member

radar commented Dec 8, 2011

Also in @190c508a90485ad25dc7979cd9fca04193b7f879, just missed tagging that one too.

Thanks for your patch!

@mikz

This comment has been minimized.

Show comment
Hide comment
@mikz

mikz Dec 8, 2011

Contributor

Thank you for such quick response. Really! Expect more to come :)

Contributor

mikz commented Dec 8, 2011

Thank you for such quick response. Really! Expect more to come :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment