Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Capybara and usage #9424

Closed
wants to merge 10 commits into from
Closed

Conversation

twalpole
Copy link
Contributor

@twalpole twalpole commented Jun 17, 2019

This updates Capybara to a current release and fixes relevant tests and Capybara usage. It also shows a test which I believe is now correctly failing, but was previously being hidden by the non-waiting behavior of all in Capybara 2.x. There are other Capybara related updates/improvements that could be done (wait_for_ajax really shouldn't be necessary) but will require more study of the expected behavior. I'll try and work on those later if there is interest.

@twalpole
Copy link
Contributor Author

FYI - the test which I believe is correctly failing now is "Checkout order's address is outside the default included tax zone so that no taxation applies to its product correctly displays other product taxless price which has been added to cart later" where the second item added does not correctly display the tax free price and instead does show in the cart as $100.

@twalpole twalpole force-pushed the capybara_upgrade branch 3 times, most recently from 9078251 to ddcad7e Compare June 21, 2019 03:25
@twalpole
Copy link
Contributor Author

twalpole commented Jun 21, 2019

@damianlegawiec Assuming the tests pass (other than the 1 failure) I think this is pretty much everything, other than the wait_for { ... } stuff around buttons which adds a lot of time, and I'm not really sure why it's there, and ready for review/merge. There's a couple of wait_for_ajax instances that couldn't be removed because success of the request isn't indicated on the page at all, and I believe the one failure is a real failure in the app.

Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you @twalpole 👍

@squash-labs
Copy link

squash-labs bot commented Jul 15, 2019

Manage this branch in Squash

Test this branch here: https://twalpolecapybara-upgrade-vdzbj.squash.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants