New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Capybara and usage #9424
Conversation
FYI - the test which I believe is correctly failing now is "Checkout order's address is outside the default included tax zone so that no taxation applies to its product correctly displays other product taxless price which has been added to cart later" where the second item added does not correctly display the tax free price and instead does show in the cart as $100. |
9078251
to
ddcad7e
Compare
@damianlegawiec Assuming the tests pass (other than the 1 failure) I think this is pretty much everything, other than the |
ddcad7e
to
b8ad16b
Compare
b8ad16b
to
ccd17e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you @twalpole 👍
Manage this branch in SquashTest this branch here: https://twalpolecapybara-upgrade-vdzbj.squash.io |
This updates Capybara to a current release and fixes relevant tests and Capybara usage. It also shows a test which I believe is now correctly failing, but was previously being hidden by the non-waiting behavior of
all
in Capybara 2.x. There are other Capybara related updates/improvements that could be done (wait_for_ajax
really shouldn't be necessary) but will require more study of the expected behavior. I'll try and work on those later if there is interest.