Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Spree 1.3: Auto capture for stripe and eway gateways #55

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jhawthorn commented Dec 21, 2012

As of spree 1.3, auto capture is determined by
PaymentMethod#auto_capture? (see spree/spree@769c1aa)

This commit makes eway and stripe always return true for auto_capture?,
removing the need for additional configuration on those gateways.

jhawthorn added some commits Dec 21, 2012

@jhawthorn jhawthorn remove misleading comment in samurai gateway
Presumably this was copied from stripe. The samurai gateway supports
authorize/capture, so there's no need to set auto_capture.
92cdd0a
@jhawthorn jhawthorn specify auto_capture? #=> true for stripe and eway
As of spree 1.3, auto capture is determined by
PaymentMethod#auto_capture? (see spree/spree@769c1aa)

This commit makes eway and stripe always return true for auto_capture?,
removing the need for additional configuration on those gateways.
4842154
Member

JDutil commented Apr 24, 2013

+1

Member

radar commented Apr 26, 2013

Looks good to me too. Thanks @jhawthorn!

@radar radar added a commit that referenced this pull request Apr 26, 2013

@jhawthorn @radar jhawthorn + radar specify auto_capture? #=> true for stripe and eway
As of spree 1.3, auto capture is determined by
PaymentMethod#auto_capture? (see spree/spree@769c1aa)

This commit makes eway and stripe always return true for auto_capture?,
removing the need for additional configuration on those gateways.

Fixes #55
a4087f9

@radar radar closed this in 41012e0 Apr 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment