New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .twig extention #28

Closed
peterfox opened this Issue Nov 21, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@peterfox
Copy link

peterfox commented Nov 21, 2014

Currently even though html and even markup files use twig syntax in files it appears you have to stick with the original extension? It would be better to be able to either config this or use files that are formatted as .html.twig etc. so that editors such as PHPStorm know how to correctly format the file as you work with it.

@carbontwelve

This comment has been minimized.

Copy link

carbontwelve commented Jan 4, 2016

👍 to this. I thought the layout_ext config setting was for this functionality, but it appears not, even though it looks like the TwigRenderizer class sets its layoutExtension property to the value of layout_ext (its set on registering 'spress.cms.renderizer' in Spress.php line 260-265).

Without setting up a development environment for spress I am unable to tell if this is supposed to be already supported.

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented Jan 4, 2016

@carbontwelve Spress 2.1.0 will incorporate this feature. layout_ext is not related with this issue. It is necessary to add a new Converter for dealing .twig files and set the html extension as output.

@yosymfony yosymfony added the 2.1 label Jan 4, 2016

@yosymfony yosymfony referenced this issue Feb 18, 2016

Closed

Map Converter for supporting .twig extension #73

1 of 1 task complete

yosymfony added a commit that referenced this issue Feb 18, 2016

`MirrorConverter` class has been replaced by `MapConverter`. See feat…
…ure #73. This fix the ticket #28 "Support .twig extention"

@yosymfony yosymfony closed this Mar 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment