New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/:basename permalink variable contains .html when using *.html.twig #78

Closed
KristiyanHristov opened this Issue Mar 30, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@KristiyanHristov
Copy link

KristiyanHristov commented Mar 30, 2016

Expected behavior

Spress should generate: index.html, about.html ...

Actual behavior

Spress generates index.html.html, about.html.html ...

Steps to reproduce the behavior

  1. make sure all layouts and pages have .html.twig extension
  2. add permalink: /:path/:basename.:extension in config.yml

Environment information

Spress Version: 2.1.0

Probable cause

The /:basename permalink variable contains .html when using the map_converter_extension feature introduced in Spress v2.1.0

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented Mar 30, 2016

Ok. I will review it.

@yosymfony yosymfony added the Bug label Mar 30, 2016

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented Apr 3, 2016

Related with #73

yosymfony added a commit that referenced this issue Apr 3, 2016

yosymfony added a commit that referenced this issue Apr 3, 2016

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented Apr 3, 2016

Thanks for the good explanation of this bug 😄

@KristiyanHristov

This comment has been minimized.

Copy link

KristiyanHristov commented Apr 4, 2016

Thanks for the good explanation of this bug 😄

thanks for the quick response

@yosymfony yosymfony closed this Apr 4, 2016

yosymfony added a commit that referenced this issue Apr 9, 2016

Fixed a bug related with dots inside of an item path and the bug #78.…
… Example of a path affected: `docs/migrating-1.x-to-2.x.md`

yosymfony added a commit that referenced this issue Apr 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment