New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same tags on different languages cause builder crash #83

Closed
urmaul opened this Issue Apr 28, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@urmaul
Copy link

urmaul commented Apr 28, 2016

Imagine you have two posts. One has tag "bash" and another one has tag "баш", which transliterates to "bash".

In this case TaxonomyGenerator tries to generate 2 tag pages with same permalink and builder crashes with error:

  [RuntimeException]
  A previous item exists with the same id: "tags/bash/index.html". Generator: "taxonomy".

BTW case insensitivity doesn't work with cyrillic characters too. TaxonomyGenerator thinks "баш" and "баШ" are different tags and fails with same error.

@yosymfony yosymfony self-assigned this May 3, 2016

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented May 7, 2016

A possible solution for this issue could be to add a suffix at the end of each term in case of conflict. e.g:

Term Path
bash /bash
баш /bash-1

And if the term "баш" is found before "bash" term then the result will be the following:

Term Path
баш /bash
bash /bash-1
@urmaul

This comment has been minimized.

Copy link

urmaul commented May 7, 2016

Or just to merge posts to one collection. In most cases both terms have same meaning.

yosymfony added a commit that referenced this issue May 11, 2016

yosymfony added a commit that referenced this issue May 11, 2016

yosymfony added a commit that referenced this issue May 14, 2016

@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented May 14, 2016

Bug fixed and merged on master. Thanks for the report

@yosymfony yosymfony closed this May 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment