New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console new:post command change separator from space to comma for tags/cats #51

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
2 participants
@lury
Copy link
Contributor

lury commented Aug 30, 2015

I think space () is a pretty popular character in category and tag names and it shouldn't be used as a separator for values while generating post via console.

This PR changes space to comma, and splits passed string into array also trimming the values to not to have spaces etc insite tag/category names.

I've updated command description and tests.

change spate separated tags/categories into comma separated - this ki…
…nd of data with high probability will contain spaces in tag/category names
@yosymfony

This comment has been minimized.

Copy link
Member

yosymfony commented Aug 31, 2015

I think this is very good.

yosymfony added a commit that referenced this pull request Aug 31, 2015

Merge pull request #51 from lury/change_space_to_comma_tags_cats
console new:post command change separator from space to comma for tags/cats

@yosymfony yosymfony merged commit 22a5310 into spress:master Aug 31, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yosymfony added a commit that referenced this pull request Aug 31, 2015

@lury lury deleted the lury:change_space_to_comma_tags_cats branch Aug 31, 2015

@yosymfony yosymfony added the 2.0 label Aug 31, 2015

@yosymfony yosymfony added this to the Spress 2.0.0 beta milestone Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment