diff --git a/spring-security-oauth2/src/main/java/org/springframework/security/oauth2/provider/endpoint/SpelView.java b/spring-security-oauth2/src/main/java/org/springframework/security/oauth2/provider/endpoint/SpelView.java index 996be819c..3a1cc3e20 100644 --- a/spring-security-oauth2/src/main/java/org/springframework/security/oauth2/provider/endpoint/SpelView.java +++ b/spring-security-oauth2/src/main/java/org/springframework/security/oauth2/provider/endpoint/SpelView.java @@ -23,6 +23,7 @@ import org.springframework.expression.Expression; import org.springframework.expression.spel.standard.SpelExpressionParser; import org.springframework.expression.spel.support.StandardEvaluationContext; +import org.springframework.security.oauth2.common.util.RandomValueStringGenerator; import org.springframework.util.PropertyPlaceholderHelper; import org.springframework.util.PropertyPlaceholderHelper.PlaceholderResolver; import org.springframework.web.servlet.View; @@ -35,19 +36,19 @@ class SpelView implements View { private final String template; + + private final String prefix; private final SpelExpressionParser parser = new SpelExpressionParser(); private final StandardEvaluationContext context = new StandardEvaluationContext(); - private PropertyPlaceholderHelper helper; - private PlaceholderResolver resolver; public SpelView(String template) { this.template = template; + this.prefix = new RandomValueStringGenerator().generate() + "{"; this.context.addPropertyAccessor(new MapAccessor()); - this.helper = new PropertyPlaceholderHelper("${", "}"); this.resolver = new PlaceholderResolver() { public String resolvePlaceholder(String name) { Expression expression = parser.parseExpression(name); @@ -68,7 +69,10 @@ public void render(Map model, HttpServletRequest request, HttpServlet .getPath(); map.put("path", (Object) path==null ? "" : path); context.setRootObject(map); - String result = helper.replacePlaceholders(template, resolver); + String maskedTemplate = template.replace("${", prefix); + PropertyPlaceholderHelper helper = new PropertyPlaceholderHelper(prefix, "}"); + String result = helper.replacePlaceholders(maskedTemplate, resolver); + result = result.replace(prefix, "${"); response.setContentType(getContentType()); response.getWriter().append(result); } diff --git a/spring-security-oauth2/src/test/java/org/springframework/security/oauth2/provider/endpoint/SpelViewTests.java b/spring-security-oauth2/src/test/java/org/springframework/security/oauth2/provider/endpoint/SpelViewTests.java new file mode 100644 index 000000000..c7b29f517 --- /dev/null +++ b/spring-security-oauth2/src/test/java/org/springframework/security/oauth2/provider/endpoint/SpelViewTests.java @@ -0,0 +1,67 @@ +/* + * Copyright 2012-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.security.oauth2.provider.endpoint; + +import static org.junit.Assert.assertEquals; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; + +import org.junit.Test; +import org.springframework.mock.web.MockHttpServletRequest; +import org.springframework.mock.web.MockHttpServletResponse; + +/** + * @author Dave Syer + * + */ +public class SpelViewTests { + + private SpelView view; + + private MockHttpServletResponse response = new MockHttpServletResponse(); + private MockHttpServletRequest request = new MockHttpServletRequest(); + + @Test + public void sunnyDay() throws Exception { + view = new SpelView("${hit}"); + view.render(Collections.singletonMap("hit", "Ouch"), request, response); + assertEquals("Ouch", response.getContentAsString()); + } + + @Test + public void nonRecursive() throws Exception { + view = new SpelView("${hit}"); + view.render(Collections.singletonMap("hit", "${ouch}"), request, response); + // Expressions embedded in resolved values do not resolve recursively + assertEquals("${ouch}", response.getContentAsString()); + } + + @Test + public void recursive() throws Exception { + // Recursive expressions in the template resolve + view = new SpelView("${${hit}}"); + Map map = new HashMap(); + map.put("hit", "me"); + map.put("me", "${ouch}"); + view.render(map, request, response); + // But expressions embedded in resolved values do not + assertEquals("${ouch}", response.getContentAsString()); + } + +}