This repository was archived by the owner on Apr 5, 2022. It is now read-only.
[pending SHL-139] XD-1536: Add ability to inject delimiter on pre-packaged jobs that deal with files. #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Grrr..no. Result of switching to IntelliJ from Eclipse. Still working out the configs for everything. I'll update.
where apropriate * Updated configuration of filejdbc, hdfsjdbc, hdfsmongodb, and jdbchdfs jobs to allow for the delimiter to be injected * Added BatchJobFiledDelimiterOptionMixin to provide metadata around new delimiter option * Updated jdbc_tests script to test the processing of a job using a tab as a delimiter.
markfisher
changed the title
ericbottard
changed the title
|
I'll look into the shell issue and get XD back on spring-shell snapshots. |
|
Merged with escaping support directly in spring-shell 8c2d0eb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pre-packaged jobs to allow a delimiter to be injected where appropriate.
filejdbc,hdfsjdbc,hdfsmongodb, andjdbchdfsjobs to allow for the delimiter to be injected
BatchJobFiledDelimiterOptionMixinto provide metadata aroundnew delimiter option
jdbc_testsscript to test the processing of a job using a tabas a delimiter.
Notes:
unescapedoes not belong inBatchJobFieldDelimiterOptionMixin, but I don't have a better place to put it right now (not familiar enough with the XD structure to know where to put a utility class like that…and it really belongs in Spring Core IMHO).\tnotation for a tab character (which OS X does not).