Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI_TEMPLATE_ATTRIBUTE used when available. Fixes gh-1302 #1327

Closed
wants to merge 7 commits into from

Conversation

JaroslawDembek
Copy link

No description provided.

dependabot bot and others added 7 commits January 23, 2024 17:19
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@OlgaMaciaszek
Copy link
Collaborator

Hello @JaroslawDembek, thanks a lot. 4.0.x is out of support now (the last release just happening today), so let's do the PR against main instead (I'm sorry for any confusion here). The feature flag would just be a boolean property that could be accessed from MicrometerStatsLoadBalancerLifecycle, as it is a bean. Then in getPath, you'd go one way or another, depending on the value of that property. The build is failing - please take a look. Let me know if you need additional pointers.

@JaroslawDembek JaroslawDembek changed the base branch from 4.0.x to main January 26, 2024 11:26
@JaroslawDembek
Copy link
Author

Deprecated base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants