New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ServiceInstance.getMetadata #162

Closed
spencergibb opened this Issue Mar 23, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@spencergibb
Member

spencergibb commented Mar 23, 2016

New from spring-cloud/spring-cloud-commons#56.

See spring-cloud/spring-cloud-zookeeper@ed8001b.

My first thought is to use tags with name=value pairs (there is precedence for that 6e4a6c6).

When proper k/v metadata comes in consul hashicorp/consul#1107, we can move this over.

@ahawtho

This comment has been minimized.

Show comment
Hide comment
@ahawtho

ahawtho Mar 24, 2016

@spencergibb Are you suggesting that we add a metadata entry only for tags of the form name=value? I had already posted on #161 with some ideas for exposing tags that conform to the hashicorp recommendations (DNS name segment compatible). We could probably make use of this approach, but it would be better IMO if there were a way to support all consul tags, especially those that follow the "official" recommendations.

ahawtho commented Mar 24, 2016

@spencergibb Are you suggesting that we add a metadata entry only for tags of the form name=value? I had already posted on #161 with some ideas for exposing tags that conform to the hashicorp recommendations (DNS name segment compatible). We could probably make use of this approach, but it would be better IMO if there were a way to support all consul tags, especially those that follow the "official" recommendations.

@spencergibb spencergibb added this to the 1.0.0.RC2 milestone Apr 5, 2016

@smcvb

This comment has been minimized.

Show comment
Hide comment
@smcvb

smcvb Apr 28, 2017

Sorry to reiterate on this, but this ticket lets me assume that the Metadata on the ServiceInstance is leveraged by Spring Cloud Consul.
The docs (on 'Metadata and Consul tags') actually suggest that it is yet to be implemented.

What is the truth in this case?

I'm currently running an app with Spring Cloud Consul set up and wanted to update the Metadata field on the localServiceInstance by grabbing it and putting additional fields in it. When I try to retrieve it after that from the localServiceInstance, I do not see any changes however.
Could this be because I'm running the Consul agent in development mode (consul agent -dev)?

smcvb commented Apr 28, 2017

Sorry to reiterate on this, but this ticket lets me assume that the Metadata on the ServiceInstance is leveraged by Spring Cloud Consul.
The docs (on 'Metadata and Consul tags') actually suggest that it is yet to be implemented.

What is the truth in this case?

I'm currently running an app with Spring Cloud Consul set up and wanted to update the Metadata field on the localServiceInstance by grabbing it and putting additional fields in it. When I try to retrieve it after that from the localServiceInstance, I do not see any changes however.
Could this be because I'm running the Consul agent in development mode (consul agent -dev)?

@spencergibb

This comment has been minimized.

Show comment
Hide comment
@spencergibb

spencergibb May 2, 2017

Member

Consul itself doesn't support metadata on services yet. We "fake" it by using name value pair tags.

Member

spencergibb commented May 2, 2017

Consul itself doesn't support metadata on services yet. We "fake" it by using name value pair tags.

@smcvb

This comment has been minimized.

Show comment
Hide comment
@smcvb

smcvb May 5, 2017

Ah alright, that's good to know, thanks.

Is there any indication when/if it will support the ServiceInstance.metadata?

smcvb commented May 5, 2017

Ah alright, that's good to know, thanks.

Is there any indication when/if it will support the ServiceInstance.metadata?

@spencergibb

This comment has been minimized.

Show comment
Hide comment
@spencergibb

spencergibb May 15, 2017

Member

I don't know

Member

spencergibb commented May 15, 2017

I don't know

@lucwillems

This comment has been minimized.

Show comment
Hide comment
@lucwillems

lucwillems Jul 23, 2018

hi ,
consul-api has now supports, in version 1.4.0 , CatalogService.nodeMeta() which seems to be the metadata for the service.
With this includes ,would it be possible to include service metadata using application.yaml ?

lucwillems commented Jul 23, 2018

hi ,
consul-api has now supports, in version 1.4.0 , CatalogService.nodeMeta() which seems to be the metadata for the service.
With this includes ,would it be possible to include service metadata using application.yaml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment