Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce explicit mode of stub downloading #287

Closed
marcingrzejszczak opened this issue Apr 27, 2017 · 2 comments · Fixed by #503

Comments

@marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Apr 27, 2017

Currently we have a combination of workOffline, repositoryRoot

  • workOffline:true, repositoryRoot:null - pick from local maven repo
  • workOffline:false, repositoryRoot:sth - download from maven repo
  • workOffline:false, repositoryRoot:null - pick from classpath

for version 1.2.0 we could consider a Spring Boot Test style of explicitly providing an option. Local, Classpath, Maven or sth like that.

@marcingrzejszczak marcingrzejszczak added this to the 1.2.0 milestone Apr 27, 2017
@hsdmiranda

This comment has been minimized.

Copy link

@hsdmiranda hsdmiranda commented May 24, 2017

Currently we are using gradle and the dependencies are downloaded to another folder that is not in the .m2/repository. Is there a way it could work offline from a local gradle repository?

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor Author

@marcingrzejszczak marcingrzejszczak commented May 24, 2017

I think that you can change the repositoryRoot to point to the directory. I wonder if Aether can even work with the Gradle cache. I doubt that it would work. You can however add the dependency as a test dependency and pick it up from classpath.

@marcingrzejszczak marcingrzejszczak modified the milestones: 1.2.0, 2.0.0 Jun 26, 2017
@marcingrzejszczak marcingrzejszczak modified the milestones: 2.0.0.M3, 2.0.0.M4 Oct 28, 2017
@marcingrzejszczak marcingrzejszczak modified the milestones: 2.0.0.M4, 2.0.0.M5 Nov 16, 2017
@marcingrzejszczak marcingrzejszczak modified the milestones: 2.0.0.M5, 2.0.0.M6 Dec 2, 2017
marcingrzejszczak added a commit that referenced this issue Dec 27, 2017
you have to explicitly provide the mode [CLASSPATH, REMOTE, LOCAL] of how you want to fetch and register stubs

fixes gh-287
@marcingrzejszczak marcingrzejszczak self-assigned this Dec 27, 2017
marcingrzejszczak added a commit that referenced this issue Dec 28, 2017
you have to explicitly provide the mode [CLASSPATH, REMOTE, LOCAL] of how you want to fetch and register stubs

fixes gh-287
marcingrzejszczak added a commit that referenced this issue Jan 3, 2018
* Introduces explicit mode of stub downloading

you have to explicitly provide the mode [CLASSPATH, REMOTE, LOCAL] of how you want to fetch and register stubs

fixes gh-287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.