Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - allow StubDownloader to keep unpacked files instead of always deleteing them #512

Closed
tomaszc opened this issue Jan 9, 2018 · 2 comments
Labels
Milestone

Comments

@tomaszc
Copy link

@tomaszc tomaszc commented Jan 9, 2018

Hi!

I would like to sometimes see what stubs were downloaded, unpacked and used for StubRunner initialization by a StubDownloader. Right now they are always deleted.

I know it is possible to get WireMock configuration providing configuration property

stubrunner.mappings-output-folder=./build/tmp/wiremock

Still I think that it would be useful to be able to inspect whole package which was downloaded and used as an input for:

  • better validation
  • being able to run WireMock manually with stubbed provider outside of the integration tests for whatever reasons

IMO it would be useful to have some configuration property like 'delete-stubs-after-test' with default value set to true.

@tomaszc

This comment has been minimized.

Copy link
Author

@tomaszc tomaszc commented Jan 9, 2018

I found the cause of always-delete feature here.

@marcingrzejszczak

This comment has been minimized.

Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Jan 9, 2018

That looks like a good idea. Thanks for the feedback!

@marcingrzejszczak marcingrzejszczak added this to the 2.0.0.M8 milestone Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.