Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MissingMethodExceptionNoStack at creating assertion for spock test #1110

Conversation

artemptushkin
Copy link
Contributor

Fixed messing method exceptions by changing assertion class to groovy with static dispatch.
see #1089 for more

Artem Ptushkin added 3 commits June 10, 2019 18:48
Changed SpringCloudContractAssertions to groovy with compileStatic
@pivotal-issuemaster
Copy link

@artemptushkin Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@artemptushkin Thank you for signing the Contributor License Agreement!

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #1110 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1110      +/-   ##
============================================
- Coverage     62.27%   62.23%   -0.04%     
+ Complexity     2763     2757       -6     
============================================
  Files           282      281       -1     
  Lines         11572    11537      -35     
  Branches       1817     1811       -6     
============================================
- Hits           7206     7180      -26     
+ Misses         3419     3412       -7     
+ Partials        947      945       -2
Impacted Files Coverage Δ Complexity Δ
...ier/assertion/SpringCloudContractAssertions.groovy 100% <100%> (ø) 1 <1> (?)
...ud/contract/wiremock/restdocs/WireMockSnippet.java 71.87% <0%> (-1.13%) 27% <0%> (-2%)
...d/contract/wiremock/WireMockRestServiceServer.java 74.7% <0%> (ø) 43% <0%> (ø) ⬇️
...oud/contract/spec/internal/FromFileProperty.groovy 0% <0%> (ø) 0% <0%> (ø) ⬇️
...remock/restdocs/WireMockRestDocsConfiguration.java 100% <0%> (ø) 2% <0%> (-1%) ⬇️
...cs/DynamicPortPlaceholderInserterPreprocessor.java
...cloud/contract/wiremock/WireMockConfiguration.java 86.77% <0%> (+2.68%) 29% <0%> (ø) ⬇️
...k/restdocs/WireMockWebTestClientConfiguration.java 100% <0%> (+12.5%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79e69f...c7fc407. Read the comment docs.

@marcingrzejszczak marcingrzejszczak merged commit 3e96da8 into spring-cloud:master Jun 19, 2019
@marcingrzejszczak
Copy link
Contributor

Thanks @artemptushkin for your contribution! :)

marcingrzejszczak pushed a commit that referenced this pull request Jun 19, 2019
…est (#1110)

* Created test for the issue #1089 - failed with MissingMethodExceptionNoStack
* Created groovy unit test for the issue #1089 - failed with MissingMethodExceptionNoStack
* Fixed MissingMethodExceptionNoStack (#1089)
* Changed SpringCloudContractAssertions to groovy with compileStatic

fixes gh-1089
@marcingrzejszczak marcingrzejszczak added this to In progress in Hoxton.M1 via automation Jun 19, 2019
@marcingrzejszczak marcingrzejszczak added this to the 2.1.2.RELEASE milestone Jun 19, 2019
@marcingrzejszczak marcingrzejszczak removed this from In progress in Hoxton.M1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants