Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate stubs at runtime #1152

Merged
merged 3 commits into from Aug 5, 2019

Conversation

@marcingrzejszczak
Copy link
Contributor

commented Aug 4, 2019

without this change the producer side must publish the stubs for the consumer side to use them
with this change the consumer can toggle a switch so that the stubs get generated at runtime. This might of course lead to false positivies but we assume that the users know what they're doing

fixes gh-881

without this change the producer side must publish the stubs for the consumer side to use them
with this change the consumer can toggle a switch so that the stubs get generated at runtime. This might of course lead to false positivies but we assume that the users know what they're doing

fixes gh-881
@marcingrzejszczak marcingrzejszczak added this to the 2.2.0.M2 milestone Aug 4, 2019
@marcingrzejszczak marcingrzejszczak added this to In progress in Hoxton.M2 via automation Aug 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #1152 into master will increase coverage by 0.1%.
The diff coverage is 48.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1152     +/-   ##
===========================================
+ Coverage     56.18%   56.28%   +0.1%     
- Complexity     3168     3178     +10     
===========================================
  Files           442      444      +2     
  Lines         15629    15702     +73     
  Branches       2089     2096      +7     
===========================================
+ Hits           8781     8838     +57     
- Misses         5936     5947     +11     
- Partials        912      917      +5
Impacted Files Coverage Δ Complexity Δ
...ork/cloud/contract/maven/verifier/ConvertMojo.java 58.62% <ø> (ø) 9 <0> (ø) ⬇️
...ct/verifier/wiremock/DslToWireMockConverter.groovy 42.85% <ø> (+9.52%) 2 <0> (ø) ⬇️
...contract/stubrunner/PactStubDownloaderBuilder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/contract/stubrunner/junit/StubRunnerRule.java 51.16% <0%> (-1.22%) 16 <0> (ø)
...rk/cloud/contract/stubrunner/MappingGenerator.java 0% <0%> (ø) 0 <0> (?)
...oud/contract/verifier/converter/StubGenerator.java 0% <0%> (ø) 0 <0> (?)
...contract/stubrunner/junit/StubRunnerExtension.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...k/cloud/contract/stubrunner/StubRunnerOptions.java 83.47% <100%> (+0.59%) 33 <1> (+1) ⬆️
...act/stubrunner/spring/StubRunnerConfiguration.java 90.69% <100%> (+0.22%) 7 <0> (ø) ⬇️
.../contract/stubrunner/StubRunnerOptionsBuilder.java 91.52% <100%> (+0.22%) 40 <1> (+1) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97db26...bb2e30d. Read the comment docs.

@marcingrzejszczak marcingrzejszczak merged commit dbb1af8 into master Aug 5, 2019
46 of 48 checks passed
46 of 48 checks passed
security/snyk - spring-cloud-contract-spec/pom.xml (spring-cloud) Manifest not found
Details
codecov/patch 48.45% of diff hit (target 56.18%)
Details
ci/circleci Your tests passed on CircleCI!
Details
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
codecov/project 56.28% (+0.1%) compared to d97db26
Details
security/snyk - docker/pom.xml (spring-cloud) No new issues
Details
security/snyk - docker/spring-cloud-contract-docker/pom.xml (spring-cloud) No new issues
Details
security/snyk - docker/spring-cloud-contract-stub-runner-docker/pom.xml (spring-cloud) No new issues
Details
security/snyk - docs/pom.xml (spring-cloud) No new issues
Details
security/snyk - pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/standalone/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock-jetty/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock-native/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock-tomcat/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock-undertow-ssl/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock-undertow/pom.xml (spring-cloud) No new issues
Details
security/snyk - samples/wiremock/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-dependencies/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-shade/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-starters/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-starters/spring-cloud-starter-contract-stub-runner-jetty/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-starters/spring-cloud-starter-contract-stub-runner/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-starters/spring-cloud-starter-contract-verifier/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-stub-runner-boot/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-stub-runner/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-tools/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-tools/spring-cloud-contract-converters/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/build.gradle (spring-cloud) No manifest changes detected
security/snyk - spring-cloud-contract-tools/spring-cloud-contract-gradle-plugin/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-tools/spring-cloud-contract-pact/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-verifier/pom.xml (spring-cloud) No new issues
Details
security/snyk - spring-cloud-contract-wiremock/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/samples-messaging-amqp/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/samples-messaging-camel/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/samples-messaging-integration/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/samples-messaging-stream/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-amqp/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-boot-eureka/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-boot-zookeeper/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-camel/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-context-path/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-integration/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-moco-contract-jar/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-moco/pom.xml (spring-cloud) No new issues
Details
security/snyk - tests/spring-cloud-contract-stub-runner-stream/pom.xml (spring-cloud) No new issues
Details
Hoxton.M2 automation moved this from In progress to Done Aug 5, 2019
@marcingrzejszczak marcingrzejszczak deleted the issues_#881_generate_stubs_at_runtime branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hoxton.M2
  
Done
1 participant
You can’t perform that action at this time.