Disable stubsJar publication by default. #1464
Conversation
|
A note is that there was an issue with the ScenarioProjectKotlinSpec with it not publishing any libraries because of the tasks being invoked. |
|
Since I wasn't fully sure if the request was to simply flip and deprecate or fully remove the functionality, I've got both prepared. |
| @@ -233,7 +233,10 @@ | |||
|
|
|||
| /** | |||
| * Is set to true will not provide the default publication task | |||
| * | |||
| * @deprecated - with 2020.0.0, the user should include stubs with their own publication(s) | |||
There was a problem hiding this comment.
Let's write with 3.0.0 cause it's the version of sc contract that matters here
| you will need to configure the publishing section for Gradle to | ||
| include the `verifierStubsJar`. To do that, you can use the | ||
| example configuration below: | ||
|
|
There was a problem hiding this comment.
I'd add a note here that since 3.0.0 the default has changed.
| @@ -193,6 +194,7 @@ class SpringCloudContractVerifierGradlePlugin implements Plugin<Project> { | |||
| } | |||
|
|
|||
| @CompileDynamic | |||
| @Deprecated | |||
| private void setPublications(def publishingExtension, TaskProvider<Task> stubsTask) { | |||
| publishingExtension.publications { | |||
| stubs(MavenPublication) { | |||
There was a problem hiding this comment.
Maybe it's worth logging a warning message here that you're using a deprecated feature scheduled for removal and please create the publication task manually?
marcingrzejszczak
added
breaking change
enhancement
and removed
waiting-for-triage
labels
|
@marcingrzejszczak, just checking in to let you know that I've made the requested changes. |
|
As usual great work @shanman190 , thanks a lot! |
Fixes gh-1168.