-
Notifications
You must be signed in to change notification settings - Fork 438
Disable stubsJar publication by default. #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A note is that there was an issue with the ScenarioProjectKotlinSpec with it not publishing any libraries because of the tasks being invoked. |
Since I wasn't fully sure if the request was to simply flip and deprecate or fully remove the functionality, I've got both prepared. |
@@ -233,7 +233,10 @@ | |||
|
|||
/** | |||
* Is set to true will not provide the default publication task | |||
* | |||
* @deprecated - with 2020.0.0, the user should include stubs with their own publication(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write with 3.0.0 cause it's the version of sc contract that matters here
you will need to configure the publishing section for Gradle to | ||
include the `verifierStubsJar`. To do that, you can use the | ||
example configuration below: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a note here that since 3.0.0 the default has changed.
@@ -193,6 +194,7 @@ class SpringCloudContractVerifierGradlePlugin implements Plugin<Project> { | |||
} | |||
|
|||
@CompileDynamic | |||
@Deprecated | |||
private void setPublications(def publishingExtension, TaskProvider<Task> stubsTask) { | |||
publishingExtension.publications { | |||
stubs(MavenPublication) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth logging a warning message here that you're using a deprecated feature scheduled for removal and please create the publication task manually?
@marcingrzejszczak, just checking in to let you know that I've made the requested changes. |
As usual great work @shanman190 , thanks a lot! |
Fixes gh-1168.