New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made AbstractKubernetesDeployer methods protected for extension. #40

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@donovanmuller
Contributor

donovanmuller commented Jul 11, 2016

Bumped kubernetes-client version to latest. Extracted getExternalPort for reuse.

Address #39

Made AbstractKubernetesDeployer methods protected for extension. Bump…
…ed kubernetes-client version to latest. Extracted getExternalPort for reuse.

@sabbyanandan sabbyanandan added the in pr label Jul 11, 2016

@@ -186,6 +181,16 @@ public AppStatus status(String appId) {
return status;
}
protected int getExternalPort(final AppDeploymentRequest request) {

This comment has been minimized.

@trisberg

trisberg Jul 11, 2016

Member

this isn't really a "getter" method, maybe name it configureExternalPort

@trisberg

This comment has been minimized.

Member

trisberg commented Jul 11, 2016

Thanks for the PR, making this more extensible makes sense. Have you signed our contributor agreement - https://github.com/spring-cloud/spring-cloud-dataflow/blob/master/spring-cloud-dataflow-docs/src/main/asciidoc/appendix-contributing.adoc

@donovanmuller

This comment has been minimized.

Contributor

donovanmuller commented Jul 11, 2016

Yes, I've signed before. I'll make the change quick and update...

Renamed getExternalPort to configureExternalPort.
As per comment: #40#discussion_r70217009
@donovanmuller

This comment has been minimized.

Contributor

donovanmuller commented Jul 25, 2016

@trisberg if all good, any chance this can be merged 😄

@trisberg

This comment has been minimized.

Member

trisberg commented Jul 25, 2016

Having trouble using the 1.3.98 version of kubernetes-client, get some errors while running the tests. Although the build succeeds, there is definitely something that has changed and our code doesn't work as expected.

Caused by: java.lang.NoClassDefFoundError: Could not initialize class io.fabric8.kubernetes.client.Adapters
    at io.fabric8.kubernetes.client.BaseClient.<init>(BaseClient.java:57) ~[kubernetes-client-1.3.98.jar:na]
    at io.fabric8.kubernetes.client.BaseClient.<init>(BaseClient.java:41) ~[kubernetes-client-1.3.98.jar:na]
    at io.fabric8.kubernetes.client.BaseClient.<init>(BaseClient.java:37) ~[kubernetes-client-1.3.98.jar:na]
    at io.fabric8.kubernetes.client.DefaultKubernetesClient.<init>(DefaultKubernetesClient.java:99) ~[kubernetes-client-1.3.98.jar:na]
    at org.springframework.cloud.deployer.spi.kubernetes.KubernetesAutoConfiguration.kubernetesClient(KubernetesAutoConfiguration.java:59) ~[classes/:na]
    at org.springframework.cloud.deployer.spi.kubernetes.KubernetesAutoConfiguration$$EnhancerBySpringCGLIB$$f3011f1f.CGLIB$kubernetesClient$2(<generated>) ~[classes/:na]
    at org.springframework.cloud.deployer.spi.kubernetes.KubernetesAutoConfiguration$$EnhancerBySpringCGLIB$$f3011f1f$$FastClassBySpringCGLIB$$41c9d87c.invoke(<generated>) ~[classes/:na]
    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.2.6.RELEASE.jar:4.2.6.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:356) ~[spring-context-4.2.6.RELEASE.jar:4.2.6.RELEASE]
    at org.springframework.cloud.deployer.spi.kubernetes.KubernetesAutoConfiguration$$EnhancerBySpringCGLIB$$f3011f1f.kubernetesClient(<generated>) ~[classes/:na]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_40]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_40]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_40]
    at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_40]
    at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:162) ~[spring-beans-4.2.6.RELEASE.jar:4.2.6.RELEASE]
    ... 38 common frames omitted
@trisberg

This comment has been minimized.

Member

trisberg commented Jul 25, 2016

Rebased and squashed, merged as commit 634ce96

Removed the version update - let's do that in a separate commit

@trisberg trisberg closed this Jul 25, 2016

@trisberg trisberg removed in pr labels Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment