New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionally resolve pom extension #94

Merged
merged 1 commit into from Jul 14, 2016

Conversation

Projects
None yet
3 participants
@donovanmuller
Contributor

donovanmuller commented Jul 11, 2016

Addresses #79

@@ -197,6 +211,11 @@ public RemoteRepository(final String url) {
this.url = url;
}
public RemoteRepository(final String url, final Authentication auth) {

This comment has been minimized.

@ilayaperumalg

ilayaperumalg Jul 14, 2016

Contributor

Do you use it somewhere? trying to understand the reasoning for this.

This comment has been minimized.

@donovanmuller

donovanmuller Jul 14, 2016

Contributor

I do but more just for teasting convenience. See here

public Authentication() {
}
public Authentication(String username, String password) {

This comment has been minimized.

@ilayaperumalg

ilayaperumalg Jul 14, 2016

Contributor

Same here. Would like to know why do you need these explicit changes.

This comment has been minimized.

@donovanmuller

donovanmuller Jul 14, 2016

Contributor

Same reason, although I should apply it

@ilayaperumalg

This comment has been minimized.

Contributor

ilayaperumalg commented Jul 14, 2016

LGTM apart from the minor comments above.

@ilayaperumalg ilayaperumalg merged commit fac89fe into spring-cloud:master Jul 14, 2016

1 check passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details

@ilayaperumalg ilayaperumalg removed the in pr label Jul 14, 2016

@ilayaperumalg

This comment has been minimized.

Contributor

ilayaperumalg commented Jul 14, 2016

LGTM, rebased and merged as fac89fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment