Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionally resolve pom extension #94

Merged
merged 1 commit into from Jul 14, 2016

Conversation

donovanmuller
Copy link
Contributor

@donovanmuller donovanmuller commented Jul 11, 2016

Addresses #79

@@ -197,6 +211,11 @@ public RemoteRepository(final String url) {
this.url = url;
}

public RemoteRepository(final String url, final Authentication auth) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use it somewhere? trying to understand the reasoning for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do but more just for teasting convenience. See here

@ilayaperumalg
Copy link
Contributor

LGTM apart from the minor comments above.

@ilayaperumalg ilayaperumalg merged commit fac89fe into spring-cloud:master Jul 14, 2016
@ilayaperumalg
Copy link
Contributor

LGTM, rebased and merged as fac89fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants