New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eureka - Ribbon - Service Version strategy #168

Closed
aivans opened this Issue Jan 20, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@aivans

aivans commented Jan 20, 2015

What strategy do you suggest for different service versions?

  1. change the spring.application.name?
    ServiceA1.0 and ServiceA2.0 as values for application.name in Eureka Server

vs

  1. Eureka custom metadata
eureka:
  instance:
    metadataMap:  
      version: ${spring.serviceVersion}

I can see this information in Eureka Server, but I am not sure it is usable by Ribbon.

@dsyer

This comment has been minimized.

Show comment
Hide comment
@dsyer

dsyer Jan 21, 2015

Contributor

The instance metadata is available to load balancer clients, so really it's up to your clients to decide how they want to behave. If you wanted to consume the instance data in a load balancer you could add a @RibbonClient and configure an ILoadBalancer or ServerListFilter that is aware of the metadata (e.g. through a DiscoveryClient).

I think it's best to avoid versioning services at all if you can, but that's another debate (and probably not one to have here).

Contributor

dsyer commented Jan 21, 2015

The instance metadata is available to load balancer clients, so really it's up to your clients to decide how they want to behave. If you wanted to consume the instance data in a load balancer you could add a @RibbonClient and configure an ILoadBalancer or ServerListFilter that is aware of the metadata (e.g. through a DiscoveryClient).

I think it's best to avoid versioning services at all if you can, but that's another debate (and probably not one to have here).

@dsyer dsyer added the question label Jan 21, 2015

@aivans

This comment has been minimized.

Show comment
Hide comment
@aivans

aivans Jan 21, 2015

Thanks Dave, I'll take a look.

Indeed, this is not the place for philosophy :)

aivans commented Jan 21, 2015

Thanks Dave, I'll take a look.

Indeed, this is not the place for philosophy :)

@aivans aivans closed this Jan 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment