New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: Do we need Feign retry? #2330

Open
eacdy opened this Issue Sep 29, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@eacdy
Copy link
Contributor

eacdy commented Sep 29, 2017

In this post: #467 .

Since we've eliminated the feign retry with our ribbon retry, Do we still need the property below?

feign:
  client:
    config:
      feignName:
        retryer: com.example.SimpleRetryer

This property is from http://cloud.spring.io/spring-cloud-static/Edgware.M1/#spring-cloud-feign-overriding-defaults .

I think we should delete this property.

ping @spencergibb

@ryanjbaxter

This comment has been minimized.

Copy link
Contributor

ryanjbaxter commented Oct 3, 2017

I agree I think we can eliminate this. Want to submit a PR?

eacdy pushed a commit to itmuch/spring-cloud-netflix that referenced this issue Oct 5, 2017

@eacdy

This comment has been minimized.

Copy link
Contributor

eacdy commented Oct 5, 2017

PR's coming. @ryanjbaxter

#2344

@spencergibb

This comment has been minimized.

Copy link
Member

spencergibb commented Oct 21, 2017

I don't know. I'd hate to remove an option even if the package provides one, there may be a case where someone wants this, why would we eliminate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment