-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feign Retryer is not configurable and overlaps with the ribbon retry. #467
Comments
Now I found that the FeignClient uses the default retryer which retries the failed requests on its own. |
Perhaps the default should be an empty As a workaround, you can create a |
Workaround works like a charm: @Bean
public Retryer retryer() {
return new Retryer() {
@Override
public void continueOrPropagate(RetryableException e) {
throw e;
}
@Override
public Retryer clone() {
return this;
}
};
} |
There's a NEVER_RETRY implementation so you can do
|
We can close this issue because all this retry logic was simplified in the latest Camden SRs and and Dalston snapshots and there is only one level of retry now. |
Can you explain what you mean by 'there is only one level of retry now'? |
We've eliminated the feign retry with our ribbon retry |
I have a consumer service calling an provider service which is running with 2 instances.
The provider interface
The ribbon configuration within the consumer service is as follows:
If there is a SocketTimeoutException during a call to the example service, I would not expect that there a retry to the next instance occurs, because POST requests are not idempotent.
But the real behavior is that there retries to the next instance occurs which causes creation of duplicate accounts aso.
In a debugging session I could see that a correct RequestSpecificRetryHandler with the ribbon config values from above will be created and as far I could see the method isRetriableException(...) of that handler returns false.
What can I do to find a solution?
Thanx
Lutz
The text was updated successfully, but these errors were encountered: