Fixed short circuit condition to correctly detect @RequestMapping shortcuts #1201 #1586

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@Infrag
Contributor
Infrag commented Jan 3, 2017

@GetMapping, @PostMaping etc.

@Infrag @Infrag Infrag Fixed short circuit condition to correctly detect @RequestMapping sho…
…rtcuts (@GetMapping, @PostMaping etc.) Fixes #1201
e4650b3
@pivotal-issuemaster

@Infrag Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@codecov-io
codecov-io commented Jan 3, 2017 edited

Current coverage is 74.20% (diff: 100%)

Merging #1586 into master will decrease coverage by 0.02%

@@             master      #1586   diff @@
==========================================
  Files           193        193          
  Lines          5937       5938     +1   
  Methods           0          0          
  Messages          0          0          
  Branches        893        894     +1   
==========================================
- Hits           4407       4406     -1   
- Misses         1206       1208     +2   
  Partials        324        324          

Powered by Codecov. Last update 1cd194a...e4650b3

@Infrag
Contributor
Infrag commented Jan 4, 2017
@ryanjbaxter

This looks OK to me, lets see what @spencergibb thinks.

@@ -388,7 +425,7 @@ TestObject getSpecificTest(@PathVariable("classId") String classId,
@RequestMapping(path = "/test/{id}", method = RequestMethod.PUT, produces = MediaType.APPLICATION_JSON_VALUE)
ResponseEntity<TestObject> getTest(@RequestHeader("Authorization") String auth,
@PathVariable("id") String id, @RequestParam("amount") Integer amount);
-
+
@ryanjbaxter
ryanjbaxter Jan 4, 2017 Contributor

Fix spacing

@spencergibb

LGTM after fixing formatting (we use spaces, not tabs).

@spencergibb
Member

Closed with some polish via 66da2d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment