disables httpclient auto decompression of encoded data #1591

Closed
wants to merge 4 commits into
from

Projects

None yet

5 participants

@tranhungt
Contributor
tranhungt commented Jan 5, 2017 edited
@tranhungt tranhungt disables httpclient auto decompression of encoded data
537792c
@pivotal-issuemaster

@tranhungt Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@tranhungt tranhungt removes empty lines
61e8a35
@codecov-io
codecov-io commented Jan 6, 2017 edited

Current coverage is 74.25% (diff: 100%)

Merging #1591 into master will increase coverage by 0.03%

@@             master      #1591   diff @@
==========================================
  Files           193        193          
  Lines          5968       5969     +1   
  Methods           0          0          
  Messages          0          0          
  Branches        897        897          
==========================================
+ Hits           4429       4432     +3   
+ Misses         1215       1213     -2   
  Partials        324        324          

Powered by Codecov. Last update fccbe1a...a869b1e

@ryanjbaxter

Should we only be disabling compression if the correct headers are set?

@tranhungt
Contributor
tranhungt commented Jan 6, 2017 edited

It's actually disabling decompression if compression exists. Nothing happens if the content isn't compressed. I can add more tests to show the other cases, if you think that's necessary.

@tranhungt tranhungt test to show that http client preserves unencoded data
f68447a
@spencergibb
Member

@tranhungt can you rebase?

@tranhungt tranhungt rebase and fix test
a869b1e
@tranhungt
Contributor

@spencergibb Yep, just did.

@spencergibb spencergibb added the ready label Jan 10, 2017
@spencergibb
Member

Rebased and merged with a little polish via 22248dd

@spencergibb spencergibb removed the ready label Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment