Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback provider #2262

Closed

Conversation

@DominikMostek
Copy link
Contributor

DominikMostek commented Sep 8, 2017

This is a followup for PR #2255. Deprecated interface is removed and documentation updated.

@spencergibb

This comment has been minimized.

Copy link
Member

spencergibb commented Sep 8, 2017

We'll need a note in the release notes

@ryanjbaxter

This comment has been minimized.

Copy link
Contributor

ryanjbaxter commented Sep 8, 2017

@spencergibb I think we can hold off on merging this until we get the 2.0.x branch building again

@ryanjbaxter ryanjbaxter added this to the 2.0.0.M3 milestone Sep 8, 2017
@ryanjbaxter ryanjbaxter added the ready label Sep 8, 2017
@spencergibb

This comment has been minimized.

Copy link
Member

spencergibb commented Oct 21, 2017

This PR needs to be rebased with all of the changes in the meantime.

@DominikMostek DominikMostek force-pushed the DominikMostek:fallback_provider_2.0 branch Oct 21, 2017
@DominikMostek

This comment has been minimized.

Copy link
Contributor Author

DominikMostek commented Oct 21, 2017

Hi @spencergibb I have rebased the changes on 2.0.x branch, However still cant build the branch.

@ryanjbaxter

This comment has been minimized.

Copy link
Contributor

ryanjbaxter commented Nov 7, 2017

@DominikMostek not even locally?

@DominikMostek DominikMostek force-pushed the DominikMostek:fallback_provider_2.0 branch Nov 8, 2017
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #2262 into 2.0.x will decrease coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.0.x    #2262      +/-   ##
==========================================
- Coverage   65.64%   64.66%   -0.98%     
==========================================
  Files         206      119      -87     
  Lines        7536     3787    -3749     
  Branches      929      457     -472     
==========================================
- Hits         4947     2449    -2498     
+ Misses       2233     1167    -1066     
+ Partials      356      171     -185
Impacted Files Coverage Δ
...reka/server/event/EurekaInstanceCanceledEvent.java
...x/zuul/ZuulRouteApplicationContextInitializer.java
...ework/cloud/netflix/turbine/TurbineProperties.java
.../cloud/netflix/eureka/server/CloudJacksonJson.java
...amework/cloud/netflix/zuul/web/ZuulController.java
...ingframework/cloud/netflix/zuul/filters/Route.java
...flix/zuul/filters/pre/Servlet30RequestWrapper.java
...ud/netflix/zuul/ZuulServerMarkerConfiguration.java
...ud/netflix/zuul/filters/CompositeRouteLocator.java
...work/cloud/netflix/zuul/ZuulFilterInitializer.java
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6dad1...bc17964. Read the comment docs.

@DominikMostek

This comment has been minimized.

Copy link
Contributor Author

DominikMostek commented Nov 8, 2017

@ryanjbaxter Now it passes when running with mvnw, but still not able to run in idea and run the tests.

@ryanjbaxter

This comment has been minimized.

Copy link
Contributor

ryanjbaxter commented Nov 8, 2017

Can you rebase again? I just pushed some fixes for some tests in the 2.0.x branch.

Also its best now to run the build by running build.sh in the scripts folder. This will build the contract test jar first and then run the netflix build.

@DominikMostek DominikMostek force-pushed the DominikMostek:fallback_provider_2.0 branch to bc17964 Nov 8, 2017
@spencergibb spencergibb modified the milestones: 2.0.0.M3, 2.0.0.M5 Nov 18, 2017
@spencergibb spencergibb removed the ready label Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.