Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoder, decoder and contract in Feign configuration properties #2687

Conversation

@khannedy
Copy link
Contributor

khannedy commented Jan 26, 2018

Support encoder, decoder and contract in Feign configuration properties

…ride the default value with properties
@ryanjbaxter ryanjbaxter added this to the 2.0.0.M6 milestone Jan 29, 2018
@ryanjbaxter

This comment has been minimized.

Copy link
Contributor

ryanjbaxter commented Jan 29, 2018

Can you merge the most recent changes from master into your branch so we can rerun the CircleCI build?

…add_endocer_decoder_contract_to_feign_configuration
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #2687 into master will increase coverage by 2.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   67.27%   69.72%   +2.44%     
==========================================
  Files         128       43      -85     
  Lines        4269     1265    -3004     
  Branches      490      130     -360     
==========================================
- Hits         2872      882    -1990     
+ Misses       1218      337     -881     
+ Partials      179       46     -133
Impacted Files Coverage Δ
...k/cloud/netflix/feign/ribbon/FeignRetryPolicy.java
...n/encoding/FeignAcceptGzipEncodingInterceptor.java
...nfig/DiscoveryClientOptionalArgsConfiguration.java
.../hystrix/dashboard/HystrixDashboardProperties.java
.../cloud/netflix/hystrix/HystrixHealthIndicator.java
...etflix/ribbon/eureka/EurekaServerIntrospector.java
...ing/FeignContentGzipEncodingAutoConfiguration.java
...ork/cloud/netflix/feign/support/SpringEncoder.java
.../cloud/netflix/feign/FeignClientSpecification.java
...DiscoveryClientConfigServiceAutoConfiguration.java
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041b493...5e8bc1a. Read the comment docs.

@khannedy

This comment has been minimized.

Copy link
Contributor Author

khannedy commented Jan 29, 2018

@ryanjbaxter please check again

@ryanjbaxter ryanjbaxter merged commit 61bbca2 into spring-cloud:master Feb 20, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
@ryanjbaxter ryanjbaxter modified the milestones: 2.0.0.M6, 2.0.0.M7 Feb 20, 2018
@khannedy khannedy deleted the bliblidotcom:features/add_endocer_decoder_contract_to_feign_configuration branch Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.