-
Notifications
You must be signed in to change notification settings - Fork 814
Add queryMapEncoder to FeignClientProperties #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0.x #630 +/- ##
============================================
+ Coverage 78.76% 79.50% +0.73%
- Complexity 519 538 +19
============================================
Files 62 65 +3
Lines 1898 1961 +63
Branches 270 273 +3
============================================
+ Hits 1495 1559 +64
- Misses 251 252 +1
+ Partials 152 150 -2
|
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KENNYSOFT Thanks for submitting the PR. It looks fine, however, more docs should have been added. Since we're planning to release 2021.0.1 today, I'm going to add them, in order to get this into the release.
|
After a further consideration, although the code looks good, I don't see that it's a needed functionality - the general model of overriding these Feign configuration elements is via adding Java beans as also described in the documentation. Is there a scenario where that is causing an issue? |
|
Actually, |
|
Just found out fe8bbbb and integrated since v3.1.1; don't care whether it included in v3.0.x or not for now. Closing with thanks! |
From #629 (comment)