Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Cloud Task support #1903

Closed
marcingrzejszczak opened this issue Apr 14, 2021 · 6 comments
Closed

Add Spring Cloud Task support #1903

marcingrzejszczak opened this issue Apr 14, 2021 · 6 comments
Projects
Milestone

Comments

@marcingrzejszczak
Copy link
Contributor

Root span would start and be reported at the point of the TaskExecutorListener. The name of the span would be spring.application.name.

Each of the CommanLineRunner or ApplicationRunner executions would be a span. The name of the span would be the bean name.

cc @mminella

@cppwfs
Copy link

cppwfs commented Apr 14, 2021

We can add this as a feature in 2.4. Thoughts @mminella .

@marcingrzejszczak
Copy link
Contributor Author

We can add it in Sleuth that's not a problem (I think we even have to do it cause otherwise we could have a release cycle Task depending on Sleuth that depends on a lot of other things). Or we would have to push Task after Sleuth if Task is not used by any other projects.

I've created this issue after talking to @mminella and we're gathering all feedback here.

@cppwfs
Copy link

cppwfs commented Apr 14, 2021

That makes sense

@marcingrzejszczak
Copy link
Contributor Author

Done via 2fca60a

@abccbaandy
Copy link

ok, so ApplicationRunner or CommandLineRunner will support in spring cloud 2021.0.0, and spring boot 2.6.X will support spring cloud 2021.0.0, right?

@marcingrzejszczak
Copy link
Contributor Author

that's the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2021.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants